Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Fixed #21322 : Declarative schema: Omitting indexType throws exception #21328

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Issue Fixed #21322 : Declarative schema: Omitting indexType throws exception #21328

merged 1 commit into from
Feb 25, 2019

Conversation

milindsingh
Copy link
Member

Description (*)

Fixed Issues (if relevant)

  1. Declarative schema: Omitting indexType throws exception #21322: Declarative schema: Omitting indexType throws exception

  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Release Line: 2.3 Community Insider: Cedcommerce community-insider-contribution labels Feb 19, 2019
@rogyar rogyar self-assigned this Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4333 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 25, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit b179e54 into magento:2.3-develop Feb 25, 2019
@ghost
Copy link

ghost commented Feb 25, 2019

Hi @milindsingh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 25, 2019
@sivaschenko
ENGCOM-4333: Issue Fixed #21322 : Declarative schema: Omitting indexT…
d030d5b 
…ype throws exception #21328
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 25, 2019
@milindsingh milindsingh deleted the issue-fix-21322-2.3-develop branch February 25, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
Award: bug fix Community Insider: Cedcommerce community-insider-contribution Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@milindsingh @magento-engcom-team @rogyar