Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] ISSUE-5021 fixed guest checkout with custom shipping carrier with underscores #21340

Merged
merged 2 commits into from
Apr 18, 2019
Merged

[Backport] ISSUE-5021 fixed guest checkout with custom shipping carrier with underscores #21340

merged 2 commits into from
Apr 18, 2019

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Feb 19, 2019

Description (*)

This is a backport of PR 19505 for Magento 2.2
See the description in #19505 for more details.

Fixed Issues (if relevant)

  1. "Please specify a shipping method" Exception #5021: "Please specify a shipping method" Exception
  2. Carrier codes with '_' (underscores) break several payment API's #13902: Carrier codes with '_' (underscores) break several payment API's

Manual testing scenarios (*)

See the steps in #19505 for more details.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

vovsky and others added 2 commits February 19, 2019 21:14
@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hostep hostep mentioned this pull request Feb 19, 2019
Closed
@rogyar rogyar self-assigned this Feb 20, 2019
@orlangur orlangur closed this Apr 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur orlangur reopened this Apr 5, 2019
@orlangur orlangur closed this Apr 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur orlangur reopened this Apr 5, 2019
@ghost ghost assigned orlangur Apr 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4687 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 11, 2019
@soleksii
Copy link

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Apr 12, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 18, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 8e19a73 into magento:2.2-develop Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2019
@sivaschenko
ENGCOM-4687: [Backport] ISSUE-5021 fixed guest checkout with custom s…
bffe14c 
…hipping carrier with underscores #21340
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 18, 2019
@nicolasddev nicolasddev mentioned this pull request Feb 24, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@rogyar rogyar

@p-bystritsky p-bystritsky

@soleksii soleksii

Labels
Component: Checkout Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
8 participants
@hostep @magento-engcom-team @soleksii @orlangur @rogyar @p-bystritsky @vovsky @nmalevanec