[2.3]creating customer without password is directly confirmed 14492

[novikor]

Description (*)

Now, customer account is not confirmed when created without password;
Account IS confirmed if customer follows create/forgot password link

Fixed Issues (if relevant)

1. Creating Customer without password is directly confirmed #14492: Creating Customer without password is directly confirmed

Manual testing scenarios (*)

Admin Panel

0. 'Require Emails Confirmation' is set to 'Yes'.
1. Admin creates account for the Customer in Admin Panel.
2. The Customer receives email with ask to change password for newly created account.
3. The Customer does not receive email for account confirmation.
4. The Customer successfully changes password for the account. The account becomes confirmed.
5. The Customer tries to login.
6. The Customer able to login for his/her account.

Frontend
Case 1

0. 'Require Emails Confirmation' is set to 'Yes'.
1. The Customer registers account with frontend registration.
2. The Customer receives confirmation email.
3. The Customer does not confirm account.
4. The Customer tries to login.
5. The Customer can not login and receive message 'This account is not confirmed. Click here to resend confirmation email.'.
6. The Customer tries to reset his/her password with'forgotpassword' functionality.
7. The Customer receives email for password reset procedure and use link from email.
8. The Customer changes his/her password. The account becomes confirmed.
9. The Customer tries to login.
10. The Customer able to login for his/her account.

Case 2

0. 'Require Emails Confirmation' is set to 'Yes'.
1. The Customer registers account with frontend registration.
2. The Customer receives email for account confirmation and use link from email.
3. The Customer confirms account.
4. The Customer tries to login.
5. The Customer able to login for his account.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @novikor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[swnsma]

Hi @novikor,

1. Please check my comments.
2. Please check failed tests.

[novikor]

Hi @novikor,

1. Please check my comments.
2. Please check failed tests.

Done. Please recheck.

[swnsma]

Please proceed with minor changes.

[swnsma]

Repeating class name in the comment is redundant. Clear responsibility description is sufficient.

[novikor]

Cannot agree, but fixed.

[novikor]

@swnsma , please review

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-4581 has been created to process this Pull Request

[sivaschenko]

Hi @novikor can you please update your branch and resolve conflicts

[novikor]

Hi, @sivaschenko . Sorry for the delay.
The branch is up to date with 2.3-develop now.

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.