Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As low as displays incorrect pricing on category page, tax appears to be added twice #21383 #21395

Merged
merged 2 commits into from
Mar 1, 2019
Merged

As low as displays incorrect pricing on category page, tax appears to be added twice #21383 #21395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9fff89
As low as displays incorrect pricing on category page, tax appears to…
Jitheesh Feb 22, 2019
70f2599
Fix static tests.
nmalevanec Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions app/code/Magento/Catalog/Pricing/Price/MinimalTierPriceCalculator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ public function __construct(CalculatorInterface $calculator)
}

/**
* Get raw value of "as low as" as a minimal among tier prices
* {@inheritdoc}
* Get raw value of "as low as" as a minimal among tier prices{@inheritdoc}
*
* @param SaleableInterface $saleableItem
* @return float|null
*/
public function getValue(SaleableInterface $saleableItem)
{
Expand All @@ -49,15 +51,17 @@ public function getValue(SaleableInterface $saleableItem)
}

/**
* Return calculated amount object that keeps "as low as" value
* {@inheritdoc}
* Return calculated amount object that keeps "as low as" value{@inheritdoc}
*
* @param SaleableInterface $saleableItem
* @return AmountInterface|null
*/
public function getAmount(SaleableInterface $saleableItem)
{
$value = $this->getValue($saleableItem);

return $value === null
? null
: $this->calculator->getAmount($value, $saleableItem);
: $this->calculator->getAmount($value, $saleableItem, 'tax');
}
}