Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused else block and corrected return types #21405

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Removed unused else block and corrected return types #21405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15ef6d7
Corrected return types
yogeshsuhagiya Feb 22, 2019
948f83d
Fix static tests.
nmalevanec Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/code/Magento/Fedex/Model/Carrier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ public function setRequest(RateRequest $request)

if ($request->getDestPostcode()) {
$r->setDestPostal($request->getDestPostcode());
} else {
}

if ($request->getDestCity()) {
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function getMessage()
/**
* Retrieve save url
*
* @return array
* @return string
* @codeCoverageIgnore
*/
public function getSaveUrl()
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/GiftMessage/Block/Cart/GiftOptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function getJsLayout()
/**
* Retrieve gift message configuration
*
* @return array
* @return string
*/
public function getGiftOptionsConfigJson()
{
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/GiftMessage/Model/Type/Plugin/Onepage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function __construct(
/**
* @param \Magento\Checkout\Model\Type\Onepage $subject
* @param array $result
* @return $this
* @return array
*/
public function afterSaveShippingMethod(
\Magento\Checkout\Model\Type\Onepage $subject,
Expand Down