Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Issue Fixed: #8086: Multiline admin field is broken #21422

Closed

Conversation

eduard13
Copy link
Contributor

Original Pull Request

#20371

Description (*)

Fixed Issues (if relevant)

  1. Multiline admin field is broken #8086: Multiline admin field is broken
  2. Multiline field is broken #18115

Manual testing scenarios (*)

  1. Add field type="multiline" in system config in admin.
  2. Save values in multiple fields

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Config Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 24, 2019
@eduard13 eduard13 requested a review from rogyar February 24, 2019 21:51
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4379 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

Hi,

Closing in favor to #21561 (create by author of original PR)

@ghost
Copy link

ghost commented Mar 4, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Config Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants