-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Checkout - Fix JS error Cannot read property 'quoteData' of undefined #21432
[Backport] Checkout - Fix JS error Cannot read property 'quoteData' of undefined #21432
Conversation
Hi @amol2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @rogyar, thank you for the review. |
✔️ QA Passed |
Hi @amol2jcommerce, thank you for your contribution! |
…'quoteData' of undefined #21432
the same bug reproduced on 2.3.1 |
Original Pull Request
#18503
Description
Sometimes after going to checkout page we have infinite loading indicator that caused by JS error
Cannot read property 'quoteData' of undefined.
This issue happened because quote.js file using window.checkoutConfig, that inserted directly into page, but sometimes quote.js component initialization executes first.
magento2/app/code/Magento/Checkout/view/frontend/web/js/model/quote.js
Lines 32 to 36 in f6ca94c
This change adding waiting when dome ready and
window.checkoutConfig
is already availableFixed Issues (if relevant)
N/A
Related issues
Manual testing scenarios
Note: This issue reproducing quote small amount of times
Contribution checklist