Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 13982 customer login block sets the title for the page when rendered #21434

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20583

Description

The main Customer Login Block, Magento\Customer\Block\Form\Loginsets up the page title.
If you use this block on any page, it rewrites the page title to "Customer Login".

Fixed Issues

  1. Customer Login Block sets the title for the page when rendered #13982: Customer Login Block sets the title for the page when rendered

Manual testing scenarios

  1. Go to Magento login page. The title of the page should be equal to "Customer Login"
  2. Insert Magento/Customer/Block/Login Block into any page
  3. The title of that page not be overridden by string "Customer Login"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4367 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost
Copy link

ghost commented Mar 5, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 5, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants