Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long string display horizontal scroll in all pages in admin #21468

Merged
merged 4 commits into from
Mar 16, 2019
Merged

Fix long string display horizontal scroll in all pages in admin #21468

merged 4 commits into from
Mar 16, 2019

Conversation

mageprince
Copy link
Contributor

@mageprince mageprince commented Feb 27, 2019

Description (*)

Search with long string display horizontal scroll in all pages in admin

Issue Screenshot

test simple product

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mageprince ,
thank you for your contribution and your time.

@phoenix128 phoenix128 self-assigned this Feb 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128, thank you for the review.
ENGCOM-4385 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @mageprince , thanks for the pull request!

On the pull request code base, the long string still does not break goes beyond the page:

image

@mageprince
Copy link
Contributor Author

mageprince commented Mar 5, 2019

@sivaschenko I have updated PR please check and approve changes.

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-21468.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned sivaschenko Mar 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4385 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Mar 6, 2019

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 16, 2019

Hi @mageprince, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants