-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fix empty cart validation #21528
[Backport] Fix empty cart validation #21528
Conversation
Hi @wojtekn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me 2.2-develop instance |
Hi @wojtekn. Thank you for your request. I'm working on Magento 2.2-develop instance for you |
Hi @wojtekn, here is your Magento instance. |
|
Hi @wojtekn. Thank you for your request. I'm working on Magento instance for you |
Hi @wojtekn, here is your new Magento instance. |
I reproduced the issue on the vanilla instance and then confirmed that PR fixes it on the instance based on the PR. |
Hi @sivaschenko, thank you for the review. |
✔️ QA Passed |
Hi @wojtekn, thank you for your contribution! |
Original Pull Request
#21295
Description
This PR prevents from running UpdateItemQty validation before Clear Shopping Cart action is triggered. In the other case validation breaks for use case in which product existing in cart went out of stock in the meantime.
Fixed Issues
Manual testing scenarios
jQuery('.action.clear').show()
It's hidden in CSS for some reason.
Contribution checklist