Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints and replace deprecated method usage #21536

Merged
merged 4 commits into from
Mar 11, 2019
Merged

Fix type hints and replace deprecated method usage #21536

merged 4 commits into from
Mar 11, 2019

Conversation

avstudnitz
Copy link
Contributor

Description (*)

Updates type hints of return value and replaces deprecated method calls like addSuccess with the newer methods like addSuccessMessage.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @avstudnitz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4409 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 6, 2019
@soleksii
Copy link

soleksii commented Mar 6, 2019

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Mar 6, 2019
orlangur
orlangur reviewed Mar 6, 2019
View reviewed changes
app/code/Magento/Newsletter/Controller/Subscriber/Confirm.php Outdated
use Magento\Framework\App\Action\HttpGetActionInterface;

/**
* Confirm subscritpion controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmalevanec please fix typo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for noticing.

@magento-engcom-team magento-engcom-team merged commit 0041ce9 into magento:2.3-develop Mar 11, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

Hi @avstudnitz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 11, 2019
@sivaschenko
ENGCOM-4409: Fix type hints and replace deprecated method usage #21536
8d0b856
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@nmalevanec nmalevanec nmalevanec left review comments

Assignees

@orlangur orlangur

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Component: Newsletter Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@avstudnitz @magento-engcom-team @soleksii @orlangur @nmalevanec