Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced-Search-layout-not-proper #21611

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Advanced Search layout not proper

Fixed Issues (if relevant)

  1. Advanced Search layout not proper #20809: Advanced Search layout not proper

Manual testing scenarios (*)

  1. Click Advanced Search link in footer

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Mar 7, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21611.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar
Copy link
Contributor

rogyar commented Mar 7, 2019

Hi @amol2jcommerce. Thank you for your collaboration. It's looks better now on desktop resolutions. However, if you take a look at iPad (portrait) resolution - the form is quite small. The contact us form has the same issue, so it's not the best example. However, if you check the create account form - it behaves much better in terms of responsive design. Try to compare the result of your solution and the create account form on different resolutions.

@rogyar rogyar self-assigned this Mar 7, 2019
@amol2jcommerce
Copy link
Contributor Author

Hi @rogyar, I updated branch please review.

@sanganinamrata
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata, here is your new Magento instance.
Admin access: https://pr-21611.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@amol2jcommerce
Copy link
Contributor Author

Hi @rogyar, I updated branch as per suggestion please review.

@rogyar
Copy link
Contributor

rogyar commented Mar 8, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21611.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4461 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@VladimirZaets VladimirZaets self-assigned this Mar 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4461 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 23e7e36 into magento:2.3-develop Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants