Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes-for-can't-scroll-in-modal-popup-on-ios #21616

Conversation

priti2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Can't scroll in modal-popup on iOS #21147: Can't scroll in modal-popup on iOS
  2. ...

Manual testing scenarios (*)

  1. Try to scrolling in the popup on an iPhone (tested on iPhone 6s Plus & iPhone X)
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 7, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ priti2jcommerce
❌ priti


priti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@priti2jcommerce priti2jcommerce force-pushed the fixes-for-can't-scroll-in-modal-popup-on-ios branch from 7cf1934 to 8dfd4b8 Compare March 7, 2019 12:18
@rogyar
Copy link
Contributor

rogyar commented Mar 8, 2019

Hi @priti2jcommerce. Please, provide the same changes within the scope of your previous PR (#21150). The mentioned PR already has history and the reviewer. So, more chances that the fix will be reviewed faster.
No reason for creating another one. Thank you!

@rogyar rogyar closed this Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants