Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2][Backport] Database Media Storage - Design Config Save functions to be Database Media Storage aware #21676

Merged
merged 1 commit into from
May 20, 2019

Conversation

gwharton
Copy link
Contributor

@gwharton gwharton commented Mar 10, 2019

Original PR (*)

#21675

Description (*)

The functions that process the uploads of the Favicon, Header Image and Transactional Email Logo files do not process the file correctly when in Database Media Storage Mode. This PR fixes that.

Fixed Issues (if relevant)

  1. Database Media Storage - Design Config fails to save transactional email logo correctly #21672: Database Media Storage - Design Config fails to save transactional email logo correctly

Manual testing scenarios (*)

  1. Setup Magento
  2. Change media storage mode to database
  3. Synchronize
  4. Save Settings
  5. Content->Configuration->Edit->Transactional Emails
  6. Upload New Image (but don't save)
  7. Verify temporary email logo exists in pub/media
  8. Verify temporary email logo exists in database
  9. Save Config
  10. Verify email logo exists in pub/media
  11. Verify email logo exists in database

Repeat for favicon and header logo, ensuring that after save, the file exists correctly in the database.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VasylShvorak
Copy link
Contributor

On hold until #21675 would be merged

…renamed aswell as the local file in pub/media.

Initialise Database Helper from Object Manager if not passed by DI. Increases backwards compatability.
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4801 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2019

Hi @gwharton, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 20, 2019
…ave functions to be Database Media Storage aware #21676
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 20, 2019
@gwharton gwharton deleted the 2.2-develop-dbmediastorage4 branch May 31, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants