Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Setting default sorting #21493 #21694

Merged

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#21498

  • Fixed default sort direction

Description (*)

PR for resolving issues customer order and cart grid sort directions. Fix based on #21493 suggestion by @iproger

Fixed Issues (if relevant)

  1. Setting default sorting #21493: Setting default sorting

Manual testing scenarios (*)

  1. Login to Magento Admin > Customers > All customers
  2. Edit customer with multiple orders
  3. Check default sorting direction, it should be based on created date in descending order by default.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned rogyar Mar 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4476 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 14, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit b4283aa into magento:2.2-develop Mar 14, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 14, 2019
@mage2pratik mage2pratik deleted the 2.2-develop-PR-port-21498 branch March 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants