Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Yes/No attribute Layered Navigation filter uses index #21772

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

stkec
Copy link
Contributor

@stkec stkec commented Mar 15, 2019

Fixes performance degradation when using Yes/No attributes in Layered navigation [#21771](Related Issue: #21771)

Description (*)

After #3283 merged it is possible to use Yes/No attributes in Layered Navigation. But when MySql engine assembles the SQL query there are 2 more places where FrontendInput of the Layered Navigation Attribute is hardcoded as ['select', 'multiselect']. As a result, Yes/No attribute processed not as a 'Term' condition as it suppose to be for Layered Attribute but as a default unknown condition

Fixed Issues (if relevant)

  1. Performance degradation in Layered navigation using Yes/No attribute #21771: Performance degradation in Layered navigation using Yes/No attribute

Manual testing scenarios (*)

  1. Set Yes/No Product attribute 'Filterable'
  2. Go to Anchor Category Page on frontend
  3. Try to apply filter by Yes/No attribute

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 15, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @stkec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4504 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@stkec thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@p-bystritsky
Copy link
Contributor

QA passed.

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @stkec, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants