Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Full Tax Summary display wrong numbers #21810

Closed
wants to merge 10 commits into from

Conversation

niravkrish
Copy link
Contributor

#20682

Description (*)

The full tax summary is displaying total tax, instead of showing individual tax value.

Fixed Issues (if relevant)

  1. Magento 2.3 Shopping Cart Taxes Missing Calc Line #19701: Magento 2.3 Shopping Cart Taxes Missing Calc Line
  2. Full Tax Summary display wrong numbers. #11358: Full Tax Summary display wrong numbers.

Manual testing scenarios (*)

  1. Manual Testing

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niravkrish,
Looks like these changes are absolutely different to original PR. Could you double check that you linked correct PR?

@ghost
Copy link

ghost commented Mar 22, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@niravkrish niravkrish closed this Mar 22, 2019
@niravkrish niravkrish deleted the patch-11358 branch March 22, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants