Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21779 Adminhtml textarea field doesn't accept maxlength #21816

Merged
merged 3 commits into from
Apr 23, 2019
Merged

#21779 Adminhtml textarea field doesn't accept maxlength #21816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dc63e8
#21779 Adminhtml textarea field doesn't accept maxlength
kisroman Mar 18, 2019
4a0fb16
Merge remote-tracking branch 'mainline/2.3-develop' into 21779
p-bystritsky Apr 18, 2019
149294b
magento/magento2#21816: Static test fix.
p-bystritsky Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/internal/Magento/Framework/Data/Form/Element/Textarea.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
* See COPYING.txt for license details.
*/

/**
* Form textarea element
*
* @author Magento Core Team <core@magentocommerce.com>
*/
namespace Magento\Framework\Data\Form\Element;

use Magento\Framework\Escaper;

/**
* Form textarea element.
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Textarea extends AbstractElement
{
/**
Expand Down Expand Up @@ -64,6 +64,7 @@ public function getHtmlAttributes()
'rows',
'cols',
'readonly',
'maxlength',
'disabled',
'onkeyup',
'tabindex',
Expand Down
7 changes: 4 additions & 3 deletions lib/internal/Magento/Framework/Data/Test/Unit/Form/Element/TextareaTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
* See COPYING.txt for license details.
*/

/**
* Tests for \Magento\Framework\Data\Form\Element\Textarea
*/
namespace Magento\Framework\Data\Test\Unit\Form\Element;

/**
* Tests for \Magento\Framework\Data\Form\Element\Textarea class.
*/
class TextareaTest extends \PHPUnit\Framework\TestCase
{
/**
Expand Down Expand Up @@ -76,6 +76,7 @@ public function testGetHtmlAttributes()
'rows',
'cols',
'readonly',
'maxlength',
'disabled',
'onkeyup',
'tabindex',
Expand Down