Refactor \Order\Shipment\AddTrack Controller to use ResultInterface

[JeroenVanLeusden]

Description (*)

Refactor \Order\Shipment\AddTrack Controller to use ResultInterface and Repository to save shipment.

Fixed Issues (if relevant)

1. None I could find.

Manual testing scenarios (*)

1. Place order.
2. Create shipment without tracking information.
3. Add tracking information to shipment.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[JeroenVanLeusden]

Will update the tests if necessary when implementation itself is correct.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-4532 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

[sidolov]

It's a good idea to add strict type to the method but unfortunately, we are not allowed to change public methods signature according to our Backward Compatible Development Guide

[JeroenVanLeusden]

@sidolov Removed the return type.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-4532 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

[ghost]

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.