Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][Review] Fix Pending Reviews label, add menu for pending review #21849

Merged

Conversation

eduard13
Copy link
Contributor

Original PR #20936

Description (*)

Fixed Issues (if relevant)

  1. Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources #20924: Reviews ACL issue - showing Reviews menu two times under System > User Roles > Add New Role > Role Resources
  2. ...

Manual testing scenarios (*)

  1. Go to System > User Roles > Add New Role > Role Resources. Changed label for Pending Reviews menu. Screenshot
  2. Added Pending Reviews menu under Marketing > User Content. Screenshot
  3. Edit a review from Pending Reviews grid then on click Back button it was redirecting to the wrong path.
  4. Edit a review from Pending Reviews grid then on Save Review it was redirecting to the wrong path. Screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from dmytro-ch March 20, 2019 08:43
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Review Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 20, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 20, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21849.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4539 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 22, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Review Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants