Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery full-screen triggers #21919

Merged

Conversation

iGerchak
Copy link
Contributor

Preconditions

  1. Magento 2.2.7

Description (*)

We find the issue when tried to select some text or value in the text field on the product page.
When you press mouse on the text and move mouse left up to the image gallery then make mouse up, on the image, it triggers full-screen gallery opening.

Steps to reproduce:

  1. Go to the product page
  2. Press mouse on the text (product description) and move mouse left up to the image gallery
  3. Make mouse up on the big gallery image

Expected result

No full-screen gallery. Just selected text.

Actual result

Full-screen gallery.

@magento-engcom-team
Copy link
Contributor

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

Tested on demo store - this issue is there:
https://demo1-m2.mage.direct/gwen-drawstring-bike-short.html
chrome-capture

So fix should be correct.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4564 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Mar 25, 2019

✔️ QA Passed

Result:

after

@Den4ik
Copy link
Contributor

Den4ik commented Apr 10, 2019

@magento-engcom-team for this issue PR was already opened. But current PR merged before earlier opened PR #21790

@orlangur
Copy link
Contributor

@Den4ik this is most likely caused by no bug report linked in this PR.

@Den4ik
Copy link
Contributor

Den4ik commented Apr 11, 2019

@orlangur yep, I understood. I opened issue, but I think @iGerchak forgot to check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants