Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Trigger contentUpdate on reviews load #21945

Merged

Conversation

eduard13
Copy link
Contributor

Original Pull Request

#21899

Description (*)

Reviews are being loaded asynchronously and since the HTML content is appended as is custom data-mage-init or text/x-magento-init scripts are not processed.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Add any <script type="text/x-magento-init"> or data-mage-init attributes to the app/code/Magento/Review/view/frontend/templates/product/view/list.phtml file.
  2. Go to a product page with reviews.
  3. When reviews are loaded the custom scripts are loaded as part of the HTML and not executed.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Review Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 26, 2019
@orlangur orlangur self-assigned this Mar 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4656 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Apr 9, 2019

✔️ QA Passed

Result:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Review Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants