Layered Navigation: “Equalize product count” not working as expected

[Nazar65]

Description (*)

Create a custom attribute of type price.
Got to Stores > Configuration > Catalog > Layered Navigation and set “price navigation step calculation” to “Automatic (equalize product counts)”

issue comes from -> #6715
where Someone says that "Both parts of ternary operators are equals."

I would expect ten ranges with equalized product counts (as the name suggests).

Fixed Issues (if relevant)

1. Layered Navigation: “Equalize product count” not working as expected #21960: Issue title
2. ...

Manual testing scenarios (*)

Create a custom attribute of type price.
Got to Stores > Configuration > Catalog > Layered Navigation and set “price navigation step calculation” to “Automatic (equalize product counts)”

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[Nazar65]

Hi @dmytro-ch why on hold ?

[dmytro-ch]

Hi @Nazar65,
thank you for your contribution!

However, the solution is a bit weird. Why do we really need the ternary operator with both equal parts?

empty($to) ? $to : $to

What is the possible case?
I guess we need to find a proper solution instead of it.

[Nazar65]

@dmytro-ch ok, let me explain , we have 2 products with values 45 and 145, so condition looks like we have 2 ranges from * to 100 and from 100 to * in this piece of code

We create labels and if $to == * {$to = '';} and bug comes here -> epmty($to) sets 0 wich is wrong, because we have wrong scenario here ->
we need $toPrice to be ''; but we have 0 and dont pass if condition and 0 will be calculated wich is wrong.
But i agree with you, Is that will be better ?

 if ($to == '*') {
              $to = null;
            }
$label = $this->renderRangeLabel(empty($from) ? 0 : $from, $to);

protected function renderRangeLabel($fromPrice, $toPrice)
    {
        $formattedFromPrice = $this->priceCurrency->format($fromPrice);
        if ($toPrice === null) {
            return __('%1 and above', $formattedFromPrice);
        } else {
            if ($fromPrice != $toPrice) {
                $toPrice -= .01;
            }
            return __('%1 - %2', $formattedFromPrice, $this->priceCurrency->format($toPrice));
        }
    }

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-4637 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

[m2-assistant]

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.