Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#20032: Download links don't work when checking out a… #21971

Closed
wants to merge 3,418 commits into from
Closed

magento/magento2#20032: Download links don't work when checking out a… #21971

wants to merge 3,418 commits into from

Conversation

max-tkachuk
Copy link
Contributor

…s guest.

Observer switched to other event.

Description (*)

Download links don't work when checking out as guest,
even when Downloadable Product Options -> Order Item Status To Enable Downloads is set to pending

Fixed Issues (if relevant)

#20032: Download links don't work when checking out as guest

Manual testing scenarios (*)

  1. Make a downloadable product with shareable links
  2. Set Admin -> Stores -> Configuration -> Catalog -> Downloadable Product Options -> Shareable to Yes
  3. Set Admin -> Stores -> Configuration -> Catalog -> Downloadable Product Options -> Disable Guest Checkout if Cart Contains Downloadable Items to No.
  4. Set Admin -> System -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status To Enable Downloads to 'Pending.'
  5. Clear cache
  6. Open a browser in incognito mode and add the downloadable product to your cart without logging in
  7. Checkout as guest with a valid email address
  8. Click on the link or links sent in the confirmation email

Contribution checklist (*)

  • [*] Pull request has a meaningful description of its purpose
  • [*] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 27, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ magento-engcom-team
✅ ihor-sviziev
✅ novikor
✅ orlangur
✅ Nazar65
✅ nmalevanec
✅ sivaschenko
❌ serhii-balko

@magento-engcom-team
Copy link
Contributor

Hi @M-A-X-I-M. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Downloadable Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Mar 27, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 27, 2019
@dmytro-ch dmytro-ch self-requested a review March 27, 2019 16:31
@dmytro-ch
Copy link
Contributor

Hi @M-A-X-I-M,
thank you for your contribution!

Please sign Contributor License Agreement, otherwise, we won't be able to process your pull request.

@swnsma swnsma mentioned this pull request Apr 10, 2019
Closed
@sidolov
Copy link
Contributor

sidolov commented Apr 24, 2019

Hi @M-A-X-I-M looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

magento-engcom-team and others added 16 commits May 5, 2019 08:40
@magento-engcom-team
Merge pull request magento#22669 to magento#22729
195d84e
@magento-engcom-team
Merge pull request magento#22670 to magento#22729
c255e8c
@magento-engcom-team
Merge pull request magento#22674 to magento#22729
78f81b9
@magento-engcom-team
Merge pull request magento#22693 to magento#22729
2c028d7
@magento-engcom-team
Merge pull request magento#22708 to magento#22729
daf6e13
@magento-engcom-team
Merge pull request magento#22713 to magento#22729
07fe9e7
@ihor-sviziev
magento/mmagento2#22729 Fox typo issues
c1d0128
@magento-engcom-team
ENGCOM-5057: Fixed Typo Issue magento#22729
5dfa6c1 
 - Merge Pull Request magento#22729 from jitendra-cedcoss/magento2:2.3-devPr0015
 - Merged commits:
   1. 7644b97
   2. 5e7123e
   3. 6d2e1bb
   4. a1b3aef
   5. e73f0dd
   6. 1b8e2a4
   7. 049c36d
   8. fd8d452
   9. ffeaa5b
   10. 5a18e50
   11. 848d21b
   12. ba1e125
   13. 1f4e759
   14. c0d189f
   15. cb6e651
   16. 45efa7c
   17. 75062eb
   18. 8d55e29
   19. 6d46c58
   20. f0e8de2
   21. 195d84e
   22. c255e8c
   23. 78f81b9
   24. 2c028d7
   25. daf6e13
   26. 07fe9e7
   27. c1d0128
@novikor
Tierprice can't save float percentage value magento#18651.
c4c76d1 
Fixed invalid zeros trimming.
@orlangur
Revert "Magento backend catalog cost without currency symbol" as Cost…
fb02b13 
… column must not be added to grid by default

This reverts commit 85beeec.
@magento-engcom-team
ENGCOM-5066: Tierprice can t save float percentage value 18651 magent…
6f2ba9e 
…o#19584

 - Merge Pull Request magento#19584 from novikor/magento2:Tierprice-can-t-save-float-percentage-value-18651
 - Merged commits:
   1. 4f318e5
   2. 5044da1
   3. c4c76d1
@magento-engcom-team
ENGCOM-5067: Revert 'Magento backend catalog cost without currency sy…
a3e636f 
…mbol' as Cost… magento#22739

 - Merge Pull Request magento#22739 from orlangur/magento2:no-cost-column-added-to-grid-by-default
 - Merged commits:
   1. fb02b13
@serhii-balko
Merge remote-tracking branch 'origin/MAGETWO-99123' into 2.3-develop-…
15dc05a 
…pr21
@serhii-balko
Merge remote-tracking branch 'origin/MAGETWO-98832' into 2.3-develop-…
f130704 
…pr21
@serhii-balko
Merge remote-tracking branch 'origin/MAGETWO-98256' into 2.3-develop-…
d6f8e99 
…pr21
@serhii-balko
Merge remote-tracking branch 'origin/MAGETWO-98187' into 2.3-develop-…
404f4f6 
…pr21
@sidolov
Copy link
Contributor

sidolov commented May 17, 2019

@M-A-X-I-M , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this May 17, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 17, 2019

Hi @M-A-X-I-M, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

irenelagno and others added 15 commits May 20, 2019 09:39
@irenelagno
MAGETWO-80146: Forward port tests for community pull request to devel…
4079802 
…op branch
@jilu1
MQE-1566: Fix mftf and zephyr tests that results in non unique match
9faef52
@irenelagno
MAGETWO-80146: Forward port tests for community pull request to devel…
069cbe5 
…op branch

-fix CR comments
@jilu1
MQE-1566: Fix mftf and zephyr tests that results in non unique match
21c2279
@dhaecker
MC-16682: Skip Flaky MFTF Tests That Rely On Shipping Calculation In …
8e352d0 
…Cart

- Skipping flaky shipping calculation tests
- Fixing MFTF test generation deprecation warnings
@viktym
Merge pull request magento#4207 from magento-tsg-csl3/MAGETWO-98844
82fac95 
[TSG-CSL3] For 2.3 (MAGETWO-98844)
@jilu1
Merge remote-tracking branch 'upstream/2.3-develop' into MQE-1566
26d7140
@magento-cicd2
merge magento/2.3-develop into magento-trigger/bugs_develop
8a62306
@magento-cicd2
merge magento/2.3-develop into magento-obsessive-owls/MAGETWO-56442
558f46e
@KevinBKozan
Merge pull request magento#4224 from magento-pangolin/MQE-1566
353322d 
[pangolin] MQE-1566: Fix mftf and zephyr tests that results in non unique match
@dhaecker
Merge branch 'MC-16682' into MAGETWO-56442
9ddee25
@magento-cicd2
merge magento/2.3-develop into magento-trigger/bugs_develop
a98a86f
@irenelagno
Merge pull request magento#4228 from magento-trigger/bugs_develop
ef04c2c 
- adding test coverage
@magento-cicd2
merge magento/2.3-develop into magento-obsessive-owls/MAGETWO-56442
d41ef98
@cspruiell
Merge pull request magento#4214 from magento-obsessive-owls/MAGETWO-5…
6494c9f 
…6442

[Owls] MC-16595
@max-tkachuk
Copy link
Contributor Author

email added to profile

@max-tkachuk max-tkachuk reopened this May 23, 2019
@ghost ghost unassigned dmytro-ch May 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @M-A-X-I-M, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@max-tkachuk max-tkachuk reopened this May 23, 2019
@dmytro-ch dmytro-ch closed this May 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @M-A-X-I-M, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch Awaiting requested review from dmytro-ch

Assignees
No one assigned
Labels
Component: Downloadable Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.