Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component Rule] Revert es6 variable declarations #21979

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Mar 27, 2019

Description (*)

Currently, we support IE 11 browser that not good supports ES6 features.

We can't add es6 to eslint cause it's will mean that we fully support ES6 but currently, it isn't.
Let and const declaration are already supported by IE11, but again, we should use all features of ES6 or don't use anything.

This PR revert es6 variable declaration via let/const

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Den4ik Den4ik changed the title [Module Rule] Revert es6 variable diclarations [Component Rule] Revert es6 variable diclarations Mar 27, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 28, 2019
@dmytro-ch dmytro-ch self-requested a review March 28, 2019 07:15
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4597 has been created to process this Pull Request

@orlangur orlangur changed the title [Component Rule] Revert es6 variable diclarations [Component Rule] Revert es6 variable declarations Mar 28, 2019
@orlangur
Copy link
Contributor

Is IE11 support going to be dropped any soon?

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants