Add multibyte support for attributeSource getOptionId method #22033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
magento-engcom-team
added
Component: Eav
Release Line: 2.3
Partner: Interactiv4
aleron75
reviewed
Apr 2, 2019
| * @param null|string $encoding | ||
| * @return int|\\lt | ||
| */ | ||
| private function mbStrcasecmp($str1, $str2, $encoding = null) |
There was a problem hiding this comment.
Hello,
why do you add an optional parameter if it's never used? Or am I missing something?
Thanks!
There was a problem hiding this comment.
Hello @gomenca, do you have any update on this? Thanks!
There was a problem hiding this comment.
Hi @aleron75 , you are right. I've just used this function in another places and used this parameter. I drop it.
aleron75
approved these changes
Apr 11, 2019
|
Hi @aleron75, thank you for the review. |
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA passed |
ghost
added
Progress: extended testing
and removed
Progress: testing in progress
labels
|
Hi @gomencal, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multibyte support for attributeSource getOptionId method
Description (*)
Currently, if a option value has special characters in UTF-8 (for instance), the use of strcasecmp PHP function causes incorrect matching, because it doesn't support multibyte strings.
Fixed Issues (if relevant)
Manual testing scenarios (*)
$value = 'Sí'; $attribute = $this->resource->getAttribute($attributeCode); $optionId = $attribute->getSource()->getOptionId($value);It must find the option value and return its Id.
Contribution checklist (*)