Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix strpos args order #22054

Merged
merged 1 commit into from
Apr 8, 2019
Merged

fix strpos args order #22054

merged 1 commit into from
Apr 8, 2019

Conversation

quasilyte
Copy link
Contributor

No description provided.

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2019

Hi @quasilyte. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 30, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned orlangur Mar 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4618 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@quasilyte thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@orlangur
Copy link
Contributor

@quasilyte please sign CLA though.

Can this automated check be integrated easily?

@soleksii soleksii self-assigned this Apr 5, 2019
@soleksii
Copy link

soleksii commented Apr 5, 2019

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Apr 5, 2019
@magento-engcom-team magento-engcom-team merged commit e21b9dc into magento:2.3-develop Apr 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @quasilyte, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 8, 2019
@sidolov
ENGCOM-4618: fix strpos args order #22054
b7413f2
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 8, 2019
@quasilyte quasilyte deleted the patch-1 branch April 8, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@p-bystritsky p-bystritsky

@soleksii soleksii

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@quasilyte @magento-cicd2 @magento-engcom-team @orlangur @soleksii @p-bystritsky