Bug fix for #21753 (2.3-develop)

[crankycyclops]

Description (*)

Fixes the issue raised in #21753 by setting the initial downloadable item status to Available if \Magento\Downloadable\Model\Link\Purchased\Item::XML_PATH_ORDER_ITEM_STATUS is set to 'Pending.'

Fixed Issues (if relevant)

1. Order Item Status to Enable Downloads is set to "Pending," but no download links are presented in "My Downloads" when logged in (fix provided) #21753

Manual testing scenarios (*)

1. Login to the admin and set Stores -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status to Enable Downloads to "Pending"
2. Create a downloadable product in the admin
3. Create a user account on the frontend and login
4. Purchase a downloadable product. The product should be placed in the "available" state after successful completion of payment.
5. Login to the admin and set Stores -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status to Enable Downloads to "Invoiced"
6. Purchase the product again and note the second ordered item is in the "pending" status.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @crankycyclops. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

Please, get value from \Magento\Sales\Model\Order\Item::STATUS_PENDING instead of hardcoded ('1') value and use the strict comparison operator ===

[crankycyclops]

I implemented all of the requested changes except for the strict comparison. If you var_dump the constant and the value returned from the admin setting, you can see that the constant is an integer while the admin setting value is a string.

[rogyar]

Hi @crankycyclops. Thank you for your collaboration. Please, check the review for minor adjustments.

[rogyar]

Great, thank you. Looks like we also need a minor adjustment to the failing unit test
https://travis-ci.org/magento/magento2/jobs/513882399

[crankycyclops]

Great, thank you. Looks like we also need a minor adjustment to the failing unit test
https://travis-ci.org/magento/magento2/jobs/513882399

Should be fixed now :)

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4685 has been created to process this Pull Request

[magento-engcom-team]

@crankycyclops thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[VasylShvorak]

✔️ QA passed

[sashas777]

@crankycyclops can you update it, please?

[crankycyclops]

@crankycyclops can you update it, please?

@sashas777 You mean merge the current 2.3-develop branch into it, right?

[sashas777]

@crankycyclops
Yes, that it can be merged. Otherwise, we won't get it in any release:D

[crankycyclops]

@crankycyclops
Yes, that it can be merged. Otherwise, we won't get it in any release:D

Done. Should be good now :)

[m2-assistant]

Hi @crankycyclops, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.