Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @SuppressWarnings and optimize imports on Category View #22074

Conversation

arnoudhgz
Copy link
Contributor

Description

Two @SuppressWarnings could be removed by splitting up the execute
method by moving logic to separate private methods.

Also the imports of this file are improved.

Manual testing scenarios

  1. Visit any category page, output should not be changed compared to before this change

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2019

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner labels Mar 31, 2019
@rogyar
Copy link
Contributor

rogyar commented Mar 31, 2019

Hi @arnoudhgz. Thank you for the refactoring. Please note that the unit tests should be adjusted correspondingly

@rogyar rogyar self-assigned this Mar 31, 2019
@arnoudhgz arnoudhgz force-pushed the optimization/category-view-remove-suppress-warnings branch from c1c6dd2 to a24b8c1 Compare April 12, 2019 19:31
@arnoudhgz
Copy link
Contributor Author

@rogyar thank you for your feedback, I have overlooked this.. Will look into it asap

Two @SuppressWarnings could be removed by splitting up the execute
method by moving logic to separate private methods.

Also the imports of this file are improved.
@arnoudhgz arnoudhgz force-pushed the optimization/category-view-remove-suppress-warnings branch from a24b8c1 to 999766c Compare April 12, 2019 21:09
@arnoudhgz
Copy link
Contributor Author

@rogyar should I also look into the Codacy thing? It is actually not a new issue.

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnoudhgz Codacy can be safely ignored in general (and I don't see what could be a better name here particularly).

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4818 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team merged commit 694dc09 into magento:2.3-develop Apr 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @arnoudhgz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants