Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on design configuration save with imageUploader form element po… #22132

Conversation

yvechirko
Copy link
Contributor

…pulated from gallery #21032

Description (*)

This change fixes all file uploads on the theme config edit form page when is used "Select from Gallery" chooser of images.

Fixed Issues (if relevant)

  1. Error on design configuration save with imageUploader form element populated from gallery #21032: Error on design configuration save with imageUploader form element populated from gallery

Manual testing scenarios (*)

  1. Log in to Admin panel
  2. Go to Content -> Design -> Configuration
  3. Click "Edit" link in a grid
  4. Expand "Header" fieldset
  5. Click "Select from Gallery" button for " Logo Image" field
  6. Select any image and click on "Add Selected" button
  7. Click the "Save Configuration" button
  8. The success message is shown (the image was stored without any errors)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @yvechirko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 3, 2019

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned orlangur Apr 3, 2019
@sidolov
Copy link
Contributor

sidolov commented Apr 5, 2019

Hi @yvechirko , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

@jurpro
Copy link

jurpro commented Apr 6, 2019

Hello. Is there any fix error of this? I have the same error. Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4800 has been created to process this Pull Request

@soleksii
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @stoleksiy. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @stoleksiy, here is your Magento instance.
Admin access: https://i-22132-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@soleksii
Copy link

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @stoleksiy. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @stoleksiy, here is your new Magento instance.
Admin access: https://pr-22132.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@soleksii
Copy link

soleksii commented Apr 23, 2019

✔️ QA Passed

Precondition:

Set pub folder as DocumentRoot in Apache2 configuration
set1

Steps to reproduce issue:

  1. Log in to Admin panel;
  2. Go to Content -> Design -> Configuration;
  3. Click "Edit" link in a grid;
  4. Expand "Header" field set;
  5. Click "Select from Gallery" button for " Logo Image" field;
  6. Select any image and click on "Add Selected" button;
  7. Click the "Save Configuration" button;

Before:
before

After:
after

Note:

If DocumentRoot is set to default, the issue #21032 is not reproducible

…o #21032_Error_on_design_configuration_save_with_imageUploader
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @yvechirko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants