Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport for Magento 2.2 - Fixes variables in configuration not being… #22140

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Apr 3, 2019

… replaced with actual values in the backend form fields.

(cherry picked from commit a8f1729)

Description (*)

This is a backport of #18067 for Magento 2.2

Fixed Issues (if relevant)

  1. Since Magento 2.2.1, certain variables in the configuration get resolved to their actual value #15972: Since Magento 2.2.1, certain variables in the configuration get resolved to their actual value

Manual testing scenarios (*)

  1. Setup a clean Magento from 2.2-develop branch
  2. In the backend configuration go to: General > Web > Base URLs & Base URLs (Secure)
  3. Enter {{unsecure_base_url}}media/ in "Base URL for User Media Files" and
    {{secure_base_url}}media/ in "Secure Base URL for User Media Files"
  4. Save Config
  5. Look at those two fields you just edited, they should remain unchanged

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… replaced with actual values in the backend form fields.

(cherry picked from commit a8f1729)
@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned orlangur Apr 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4662 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Result:

after1
after2

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants