Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unused variable from order_list fixture in the integration test suite. #22220

Conversation

evktalo
Copy link
Contributor

@evktalo evktalo commented Apr 8, 2019

Description (*)

Small code clean-up for integration tests. Remove an unused variable.

Remove unused payment variable from order data. The $payment variable is overwritten in the foreach loop.

Manual testing scenarios (*)

  1. Running the integration tests should still pass

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

The $payment variable is overwritten in the foreach loop.
@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @evktalo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Apr 8, 2019
@@ -9,6 +9,7 @@
use Magento\Sales\Model\Order\Address as OrderAddress;
use Magento\Sales\Model\Order\Payment;

// phpcs:ignore Magento2.Security.IncludeFile
require 'order.php';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously? :D We now have such rule? Lol.

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @evktalo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants