Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper variables for tooltip styles on tablet devices #22258

Conversation

vovayatsyuk
Copy link
Member

Description

There are variables available for tooltip customization. This commit fixes an issue
on tablet devices when trying to use them.

Manual testing scenarios

  1. Open Magento/blank/Magento_Checkout/web/css/source/module/checkout/_tooltip.less file and change the values of the tooltip variables as follows (Usually we do this via theme, but it's for testing purpose only):

    @checkout-tooltip-content__background-color: #fff;
    @checkout-tooltip-content__border-color: #f2f5f7;
    @checkout-tooltip-content__active__border-color: @checkout-tooltip-content__border-color;
  2. Navigate to checkout and chec the new styles of field tooltips

  3. Set the width to 768px and check them again:

    Without patch With patch
    image image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2019

Hi @vovayatsyuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor

Karlasa commented Apr 10, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-22258.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4722 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @vovayatsyuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants