Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the correct subtotal amount for partial creditmemo email #22265

Merged
merged 1 commit into from
Apr 20, 2019

Conversation

kassner
Copy link
Contributor

@kassner kassner commented Apr 10, 2019

Description

The creditmemo e-mail has the wrong subtotal for line items when the creditmemo is partial:

Screenshot from 2019-04-10 12-15-56

In this example, the order has 3x Test product, which costs 200 SEK. The creditmemo was for just one product, reflected in the Qty column, but the Subtotal column is using the order item to calculate it. This value should have been SEK200.00 instead.

Manual testing scenarios

  1. Place an order with more with one product and quantity 2;
  2. Invoice the order;
  3. Create a creditmemo for just one quantity;
  4. Check the e-mail line items;

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2019

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4740 has been created to process this Pull Request

@AlexWorking AlexWorking self-assigned this Apr 15, 2019
@ghost ghost unassigned AlexWorking Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants