Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #22223 Missing/Wrong data display on downloadable report table … #22291

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

shikhamis11
Copy link
Member

Fixed #22223 Missing/Wrong data display on downloadable report table reports > downloads in BO

Preconditions (*)

  1. At least Magento 2.1.11 to 2.3.1 are concerned

Steps to reproduce (*)

1.Create 22 downloadable products
2.Order the 22 downloadable products
3. Complete the order in BO
3.Visit the downloadable links to download bought products (from frontend customer account)
4 Go go downloads reports table in the backoffice at reports>downloads

Expected result (*)

  1. Should've found 22 records / products with their download count as well as a pagination

good_report_pagination_ok

Actual result (*)

  1. Only 1 records found also the table only show the first 20 products with no pagination

only_first_20_product

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Apr 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4747 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@seyuf
Copy link

seyuf commented Apr 15, 2019

Hi im the one that created the issue.
This PR does not seem to fix it @stoleksiy.

@shikhamis11
Copy link
Member Author

Hi @seyuf
on which version your are testing the fix ??

@shikhamis11
Copy link
Member Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your new Magento instance.
Admin access: https://pr-22291.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@seyuf
Copy link

seyuf commented Apr 15, 2019

Hi @shikhamis11 magento 2.3.1 but the fix should behave the same on every version i believe.

@shikhamis11
Copy link
Member Author

yes fix should be same
can u please test it on test instance ?

@seyuf
Copy link

seyuf commented Apr 15, 2019

I have tested it locally it would take too much time to create the products on the vanilla instance. On what version have you tested you're code? Locally i mean?

@seyuf
Copy link

seyuf commented Apr 15, 2019

@shikhamis11 my bad it's working i just tested it on a fresh 2.3.1 install.
Good job 👍

@p-bystritsky p-bystritsky self-assigned this Apr 16, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment