[Fixed] Category Update without "name" cannot be saved in scope "all" with REST API

[niravkrish]

Description (*)

• Category update API threw error for required field "name".

Fixed Issues (if relevant)

1. Category Update without "name" cannot be saved in scope "all" with REST API #22309: Category Update without "name" cannot be saved in scope "all" with REST API

Manual testing scenarios (*)

1. Manual Testing

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@niravkrish why it works on scope "default" without such change and does not work on "all" scope?

[niravkrish]

@niravkrish why it works on scope "default" without such change and does not work on "all" scope?

Hello @orlangur ,
In this solution the key name is not sent.
If not set in data Body required to update.
So this solution is working fine with all and default as well.

[orlangur]

@niravkrish why "default" scope update works without such change?

We cannot add null as allowed value as proper category name cannot be null.

[niravkrish]

@niravkrish why "default" scope update works without such change?

We cannot add null as allowed value as proper category name cannot be null.

This can not allow to add or set null value to Category name.
It is used to get Category Name as a string or if not then null.

This is not pass null on save the data to database or anywhere.

If we are not passing the name from request body the name key is set with null before and after applying this solution the key is set when there is name key is available with value.

please let me know for further changes.

Thanks
Nirav Patel

[orlangur]

@niravkrish ow, we allow null value for any other getter here.

Still don't get why the bug is in "all" scope only but fix seems reasonable.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4771 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.