[Fixed] Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL

[niravkrish]

Description (*)

Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL

Fixed Issues (if relevant)

1. Checkout: it is possible to leave blank Shipping Details section and get to Payment Details section by URL #21596: Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL

Manual testing scenarios (*)

1. Product Add To Cart and go to checkout page
2. hit payment url without adding shipping address

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-4783 has been created to process this Pull Request

[ghost]

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[ghost]

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[ghost]

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[ghost]

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[ghost]

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-4783 has been created to process this Pull Request

[sidolov]

@VasylShvorak please, verify case with virtual product (when shipping step is skipped).

[VasylShvorak]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @VasylShvorak. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @VasylShvorak, here is your new Magento instance.
Admin access: https://pr-22405.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[VasylShvorak]

✔️ QA passed
Result:

[m2-assistant]

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[csdougliss]

Is this a replacement for #21597?

[niravkrish]

Is this a replacement for #21597?

Yes, @craigcarnell

[arunelangovan]

This will not work in case if only digital products in cart, When there is only digital products in cart and you have to go to payment step by default. But this code sends them to shipping and which in-turn sends user to 404 page. I had experienced it on 2.2.9 and i have to remove this piece of code to accommodate digital orders through checkout.

@magento-engcom-team FYI