Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Exception While Creating an Order in the Admin #22606

Merged
merged 1 commit into from
May 10, 2019
Merged

Fix Exception While Creating an Order in the Admin #22606

merged 1 commit into from
May 10, 2019

Conversation

justin-at-bounteous
Copy link
Contributor

Changes:

  • $total->getDiscountDescription() returns a Phrase, but strlen expects a string
  • $total->getDiscountDescription()->getText() will return a string

@m2-assistant
Copy link

m2-assistant bot commented May 2, 2019

Hi @justin-at-bounteous. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur requested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

app/code/Magento/SalesRule/Model/Quote/Address/Total/ShippingDiscount.php Outdated Show resolved Hide resolved
@ghost ghost assigned orlangur May 2, 2019
@justin-at-bounteous
Fix Exception While Creating an Order in the Admin
ffdbf85 
Changes:
 - $total->getDiscountDescription() returns a Phrase, but strlen expects a string
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5034 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 6, 2019
@nmalevanec nmalevanec self-assigned this May 6, 2019
@soleksii
Copy link

soleksii commented May 6, 2019

✔️ QA Passed

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 10, 2019
@sidolov
ENGCOM-5034: Fix Exception While Creating an Order in the Admin magen…
6a23cd8 
…to#22606
@magento-engcom-team magento-engcom-team merged commit ffdbf85 into magento:2.3-develop May 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 10, 2019

Hi @justin-at-bounteous, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Component: SalesRule Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@justin-at-bounteous @magento-engcom-team @soleksii @orlangur @nmalevanec