Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22562: Fix price getting populated on child item for configurable item in order JSON #22723

Closed
wants to merge 1 commit into from
Closed

#22562: Fix price getting populated on child item for configurable item in order JSON #22723

wants to merge 1 commit into from

Conversation

sanjay-wagento
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Price getting populated on child item in order JSON #22562: Price getting populated on child item in order JSON
  2. Quote Item Prices are NULL in cart related events. #18685: Quote Item Prices are NULL in cart related events

Manual testing scenarios (*)

  1. Create Configurable item
  2. Create order using the configurable item
  3. get order JSON using order API
    Rest Endpoint Url: WEBSITE_URL/rest/V1/orders/{$orderId}
    Method: GET

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @sanjay-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Quote Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels May 4, 2019
@sanjay-wagento
Copy link
Contributor Author

@magento-team I can see database compare build failed but this was a requirement.
For configurable product order, child item does not have price.

@VladimirZaets
Copy link
Contributor

Hi @sanjay-wagento. Thanks for collaboration. According to rules, the main branch is 2.3-develop and we should deliver code to it first.

@orlangur
Copy link
Contributor

Closing as there is no corresponding PR targeting 2.3-develop branch created.

@orlangur orlangur closed this Jul 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2019

Hi @sanjay-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Quote Event: dmcdindia1 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: on hold Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants