Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #22788 #22791

Merged
merged 1 commit into from
May 14, 2019
Merged

Fixed issue #22788 #22791

merged 1 commit into from
May 14, 2019

Conversation

gaurav-473
Copy link
Contributor

Fixed issue #22788 New Shipment emails do not generate

Preconditions (*)

  1. Magento 2.3.1 Open Source
  2. Ubuntu 16.04, PHP 7.2, Apache 2.4.18

Steps to reproduce (*)

  1. Go to Marketing > Email Templates
  2. Add Template
  3. Load magento_sales > New Shipment (Default Template with no custom changes)
  4. Press Load
  5. Preview Template

Expected result (*)

  1. The Template Preview Tab loads with the default contents

Actual result (*)

  1. The Template Preview Tab is blank. The only HTML source code is below
<html lang="en"><head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
    <title>Email Preview</title>
</head>
<body>
    </body>
</html>

Further Notes: When you remove the below line from the Default Template, the Template Preview loads:

{{block class='Magento\\Framework\\View\\Element\\Template' area='frontend' template='Magento_Sales::email/shipment/track.phtml' shipment=$shipment order=$order}}

template-ok

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned VladimirZaets May 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5090 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this May 10, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this May 10, 2019
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 14, 2019
@sidolov
ENGCOM-5090: Fixed issue magento#22788 magento#22791
63fda1a
@magento-engcom-team magento-engcom-team merged commit 84da62e into magento:2.3-develop May 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 14, 2019
@mahesh-rajawat mahesh-rajawat mentioned this pull request May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Area: Frontend Community Insider: Cedcommerce community-insider-contribution Component: Sales Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@gaurav-473 @magento-engcom-team @VasylShvorak @VladimirZaets @nmalevanec