Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] fixed Quote Item Prices are NULL in cart related events. #18685 #23839

Merged

Conversation

edenduong
Copy link
Contributor

Original Pull Request

#18808

Description (*)

before these two observers checkout_cart_product_add_after, checkout_cart_product_update_after cart item is not saved into the database the object is only created and in the object price was not set but custom price was set so there was no issue of custom price, we could have added the price in the item from two files:
app/code/Magento/Quote/Model/Quote/Item/Processor.php and
app/code/Magento/Quote/Model/Quote.php
I have added the price in this file app/code/Magento/Quote/Model/Quote/Item/Processor.php

Fixed Issues (if relevant)

  1. Quote Item Prices are NULL in cart related events. #18685: Quote Item Prices are NULL in cart related events

Manual testing scenarios (*)

  1. create a module which has observers for these two events checkout_cart_product_add_after, checkout_cart_product_update_after cart
  2. now in the observer try to get the added item price by calling $observer->getEvent()->getQuoteItem()->getPrice()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento magento deleted a comment from m2-assistant bot Jul 24, 2019
@magento magento deleted a comment from m2-assistant bot Jul 24, 2019
@magento magento deleted a comment from m2-assistant bot Jul 24, 2019
@edenduong
Copy link
Contributor Author

Forward Port From 2.2 to 2.3

@ghost ghost assigned swnsma Jul 31, 2019
@swnsma swnsma added the Port label Jul 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5521 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@swnsma swnsma added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 31, 2019
@engcom-Delta engcom-Delta self-assigned this Jul 31, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants