-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed getting error in console while selecting all downloadable links #24633 #24634
Conversation
Hi @rani-webkul. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
app/code/Magento/Downloadable/view/frontend/templates/catalog/product/links.phtml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rani-webkul,
Your changes looks good to me.
- Could you squash your changes to single commit?
- Would be great to cover your changes with some tests. Will you be able to do that?
Could you squash your changes to single commit? |
@rani-webkul unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request |
Hi @rani-webkul, |
@ihor-sviziev could you please help me for tests coverage? |
Hi @rani-webkul, There we could add MFTF test for this feature. Docs are here: https://devdocs.magento.com/mftf/docs/introduction.html The most close test case I think is following: https://github.com/magento/magento2/blob/e93feb02398f158f79fefb14de95cf93e3ec0786/app/code/Magento/Downloadable/Test/Mftf/Test/VerifyDisableDownloadableProductSamplesAreNotAccessibleTest.xml BTW it's not hard requirement, we could approve it without tests, but it's highly recommended to cover all changes in order not to add regression in future. |
Hi @ihor-sviziev , Thanks for helping.. I'm now writing the test coverage for this PR. |
@rani-webkul, as I understood that JS error caused broken functionality "select all"/"unselect all", idea is just add checking that this functionality works fine, not check that we don't have JS errors. Also you could look at https://github.com/magento/magento2/pull/24580/files#diff-5ea8a7b56c95d845707926c666af76c4 . It's still not merged, but that's your PR, it might help you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rani-webkul,
Please check my comments
...de/Magento/Downloadable/Test/Mftf/Test/SelectAllDownloadableLinksDownloadableProductTest.xml
Outdated
Show resolved
Hide resolved
...de/Magento/Downloadable/Test/Mftf/Test/SelectAllDownloadableLinksDownloadableProductTest.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rani-webkul,
Unfortunately functional tests failed. Please review & fix them.
...de/Magento/Downloadable/Test/Mftf/Test/SelectAllDownloadableLinksDownloadableProductTest.xml
Outdated
Show resolved
Hide resolved
...de/Magento/Downloadable/Test/Mftf/Test/SelectAllDownloadableLinksDownloadableProductTest.xml
Outdated
Show resolved
Hide resolved
Hi @ihor-sviziev, thank you for the review. |
✔️ QA passed |
Hi @rani-webkul, thank you for your contribution! |
… #24633
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)