Refactor apply options of sales rule to it's own source model to simplify extending it #24665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
In current Magento version, if some module needs to add it's own sales rule actions it needs to add plugin on
\Magento\SalesRule\Model\Rule\Metadata\ValueProvider
class and modify whole metadata class. This PR makes it easier to add/modify those actions by creating own source class for those options. Now it also becomes consistent with Catalog Rules module.Fixed Issues (if relevant)
Manual testing scenarios (*)
after
plugin onMagento\SalesRule\Model\Rule\Action\SimpleActionOptionsProvider
and add new option to the arrayQuestions or comments
Contribution checklist (*)