Fix wording of downloadable Products #2776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see also #2775 |
|
hello @bh-ref , can you please update code and cover it by Travis tests? |
|
@KrystynaKabannyk unfortunately, I do not know how to write the needed Travis tests or even where to put them. But feel free to reject this pull request and maybe solve it another way. |
|
@bh-ref, sorry for the confusion, I meant that you should cover the code by automated tests and have a green run on Travis. |
|
@bh-ref, as provided fix couldn't be a reason of errors appeared in Travis log please try to just rerun tests. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 9, 2018
[thunder] MAGETWO-93042: [Backport to 2.2 ] Write Logs for Failed Process of Generating Factories in Extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.