Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant init method #28650

Merged
merged 3 commits into from
Jul 11, 2020
Merged

Remove redundant init method #28650

merged 3 commits into from
Jul 11, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jun 9, 2020 •
edited by m2-assistant bot
Loading

Description (*)

This PR removes redundant init method in
app/code/Magento/AdvancedPricingImportExport/Model/Import/AdvancedPricing/Validator/Website.php and app/code/Magento/AdvancedPricingImportExport/Model/Import/AdvancedPricing/Validator/TierPriceType.php
this method just call parent public method

Resolved issues:

  1. resolves [Issue] Remove redundant init method #29009: Remove redundant init method

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: AdvancedPricingImportExport Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 9, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 9, 2020

@magento run all tests

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 9, 2020

@magento run all tests

lbajsarowicz
lbajsarowicz approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Nice catch!

app/code/Magento/AdvancedPricingImportExport/Model/Import/AdvancedPricing/Validator/Website.php Outdated
@@ -63,6 +61,7 @@ protected function isWebsiteValid($value, $websiteCode)
* Validate value
*
* @param mixed $value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to replace mixed with the appropriate type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ghost ghost assigned lbajsarowicz Jun 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7657 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests B2B

1 similar comment
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests B2B

@engcom-Delta engcom-Delta self-assigned this Jul 1, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked Advanced Pricing Import works as before PR changes

@engcom-Charlie engcom-Charlie self-assigned this Jul 2, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 2, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 6, 2020
Closed
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 6, 2020
@engcom-Charlie engcom-Charlie added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: testing in progress and removed Progress: accept labels Jul 7, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 7, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020
@slavvka
ENGCOM-7657: Remove redundant init method #28650
27087bb
@magento-engcom-team magento-engcom-team merged commit 2720d91 into magento:2.4-develop Jul 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 11, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: AdvancedPricingImportExport Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] Remove redundant init method
6 participants
@Usik2203 @magento-engcom-team @engcom-Delta @lbajsarowicz @slavvka @engcom-Charlie