Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17] Read API Integration tests Magento StorefrontGraphQl #63 [… #28746

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

skovalenk
Copy link
Contributor

@skovalenk skovalenk commented Jun 16, 2020

Description (*)

Integration tests were fixed.
Reindexations were added to fixtures

Related Pull Requests

[https://github.com/magento/catalog-storefront/pull/77](Store Front)

Fixed Issues (if relevant)

Fixes magento/catalog-storefront/#55

[https://github.com/magento/catalog-storefront/issues/55](Customer rests)
[https://github.com/magento/catalog-storefront/issues/65](Version CMS)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 16, 2020

Hi @skovalenk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@mslabko mslabko changed the base branch from 2.4-develop to storefront-2.4 June 16, 2020 22:00
@mslabko mslabko merged commit f6ab582 into magento:storefront-2.4 Jun 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 16, 2020

Hi @skovalenk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants