Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Sharing Wishlist with more than allowed Text Length Limit #28812

Merged
merged 3 commits into from
Jul 11, 2020
Merged

MFTF: Sharing Wishlist with more than allowed Text Length Limit #28812

merged 3 commits into from
Jul 11, 2020

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Jun 19, 2020 •
edited by m2-assistant bot
Loading

This PR contains a test for sharing customer's wishlist with more than allowed Text Length Limit

Steps to reproduce:

1 - Set maximum allowed Text Length Limit for sharing
2 - Login as a customer
3 - Add product into wishlist
4 - Share wishlist with more than maximum allowed Text Length Limit
5 - Perform Assertions

Resolved issues:

  1. resolves [Issue] MFTF: Sharing Wishlist with more than allowed Text Length Limit #28969: MFTF: Sharing Wishlist with more than allowed Text Length Limit

@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Wishlist Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 19, 2020
@dmytro-ch dmytro-ch self-assigned this Jun 19, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

lbajsarowicz
lbajsarowicz approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contribution is fine, but after verifying error you can add steps to verify if after amends it works properly. Why? Sometimes the validators get stuck with some js / session data issues

...list/Test/Mftf/Test/StorefrontShareWishlistWithMoreThanMaximumAllowedTextLengthLimitTest.xml
<createData entity="SimpleProduct" stepKey="createProduct">
<requiredEntity createDataKey="createCategory"/>
</createData>
<magentoCLI command="cron:run --group=index" stepKey="runCronIndexer"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have magentoCron command available 👍

@ghost ghost assigned lbajsarowicz Jun 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7717 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 22, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7717 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jul 2, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 2, 2020
Closed
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Jul 2, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 2, 2020
@engcom-Delta engcom-Delta added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 6, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@slavvka slavvka added this to the 2.4.1 milestone Jul 7, 2020
@slavvka slavvka added the Priority: P3 May be fixed according to the position in the backlog. label Jul 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020
@slavvka
ENGCOM-7717: MFTF: Sharing Wishlist with more than allowed Text Lengt…
897ed31 
…h Limit #28812
@magento-engcom-team magento-engcom-team merged commit 930c943 into magento:2.4-develop Jul 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 11, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Sharing Wishlist with more than allowed Text Length Limit
7 participants
@DmitryTsymbal @dmytro-ch @magento-engcom-team @engcom-Delta @engcom-Charlie @lbajsarowicz @slavvka