Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest print order form fixes #29309

Conversation

kodubovik
Copy link
Contributor

@kodubovik kodubovik commented Jul 28, 2020

Description (*)

This pull request fixes an issue with guest print order form when a customer inputs data with trailing/leading spaces. The expected result is that spaces are trimmed and order printed successfully.
It also improves Unit tests and Functional tests to cover cases when zip code is used to search for an order on the print guest order page.

Manual testing scenarios (*)

  1. Place an order as a guest
  2. Go to the page "sales/guest/form/" on the storefront as a guest.
  3. Fill in the print order form:
    • Try to search for an order by email
    • Try to search for an order by zip code
    • Try to input data with trailing/leading spaces

In all cases, you should be able to print the order.

Related Pull Requests

#30102

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Guest print order form fixes #29337: Guest print order form fixes

@kodubovik
Copy link
Contributor Author

@magento run all tests

@edenduong edenduong self-assigned this Jul 29, 2020
@edenduong
Copy link
Contributor

Hi @kodubovik: Thank you for your contribution. Please solve the problem about static test.

@VladimirZaets
Copy link
Contributor

@magento create issue

@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 30, 2020
@kodubovik
Copy link
Contributor Author

@magento run all tests

@kodubovik kodubovik force-pushed the bug/guest-print-order-form-input-trim-spaces branch from 989615f to d2c368b Compare August 8, 2020 10:00
@kodubovik
Copy link
Contributor Author

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-8044 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Sep 2, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 2, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Place an order as a guest;
  2. Go to the page "sales/guest/form/" Orders and Returns on the storefront as a guest;
  3. Fill in the print order form with spaces in each field:

Try to search for an order by email:

Before: ✖️ You entered incorrect data. Please try again

Peek 2020-09-02 11-22

After: ✔️ Order information was successfully displayed

Peek 2020-09-02 11-28

Try to search for an order by zip code:

After: ✔️ Order information was successfully displayed

Peek 2020-09-02 11-50

Also, was tested Orders and Returns widget and everything works as expected.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Hi, @kodubovik. Can you please resolve the conflict?

… bug/guest-print-order-form-input-trim-spaces

� Conflicts:
�	app/code/Magento/Store/Test/Mftf/Test/StorefrontAddStoreCodeInUrlTest.xml
@engcom-Echo
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2020

Hi @kodubovik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit dc1560f into magento:2.4-develop Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: LoginAsCustomer Component: Sales Partner: Guidance Solutions partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Guest print order form fixes
6 participants