#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

yolouiese · 2020-08-05T11:19:32Z

Need to verify (*)

deleted tags have been removed after clicking save

Description (*)

Replaced the outdated keywords after new image details have been saved

Fixed Issues (if relevant)

Fixes The deleted tags are not removed from Tags drop-down until the web page is refreshed adobe-stock-integration#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed

Manual testing scenarios (*)

Select the uploaded image by clicking on it
Click "three dots", select Edit
Add three new Tags, for example. Click Save
Click "three dots" again, and select Edit
Remove the previously added Tags by clicking on the cross (x) near them
Click Save
Click "three dots" again, and select Edit

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…til the web page is refreshed - replaced outdated keywords after saving new details

m2-assistant · 2020-08-05T11:19:34Z

Hi @yolouiese. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

yolouiese · 2020-08-05T11:20:02Z

@magento run all tests

sivaschenko

Thanks for the pull request @yolouiese , can you please cover this case with MFTF test

…eleted-tags-not-removed

…til the web page is refreshed - covered MFTF test

…eleted-tags-not-removed

sivaschenko

Thanks for updates @yolouiese ! Please see my comments

sivaschenko · 2020-08-11T10:47:29Z

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js

+         * @param {String} id
+         * @param {String} tags
+         */
+        removeCached: function (id, tags) {


I would simply remove cached image and rely on reloading from the backend to make sure frontend and backend are on the same page

sivaschenko · 2020-08-11T10:49:16Z

...ode/Magento/MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyUpdatedTagsTest.xml

+        <actionGroup ref="AdminEnhancedMediaGalleryUploadImageActionGroup" stepKey="uploadImage">
+            <argument name="image" value="ImageUpload"/>
+        </actionGroup>
+        <actionGroup ref="AdminEnhancedMediaGalleryImageDetailsEditActionGroup" stepKey="editImage"/>


I think AdminEnhancedMediaGalleryViewImageDetails should be executed before this step

sivaschenko · 2020-08-11T10:50:55Z

...ode/Magento/MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyUpdatedTagsTest.xml

+        <actionGroup ref="AdminEnhancedMediaGalleryVerifyImageKeywordsActionGroup" stepKey="verifyAddedKeywords">
+            <argument name="keywords" value="UpdatedImageDetails.keyword"/>
+        </actionGroup>
+        <actionGroup ref="AdminEnhancedMediaGalleryVerifyImageKeywordsActionGroup" stepKey="verifyMetadataKeywords">


Can you please also verify the removal of the keyword

…til the web page is refreshed - covered MFTF test

yolouiese · 2020-08-11T17:15:33Z

@magento run all tests

…eleted-tags-not-removed

…til the web page is refreshed - added verify removal of keyword MFTF test

yolouiese · 2020-08-12T10:13:01Z

@magento run all tests

sivaschenko · 2020-08-13T14:35:17Z

@magento run all tests

sivaschenko · 2020-08-14T09:04:24Z

...ode/Magento/MediaGalleryUi/Test/Mftf/Section/AdminEnhancedMediaGalleryEditDetailsSection.xml

@@ -14,6 +14,7 @@
        <element name="description" type="textarea" selector="#description"/>
        <element name="newKeyword" type="input" selector="[data-ui-id='keyword']"/>
        <element name="addNewKeyword" type="input" selector="[data-ui-id='add-keyword']"/>
+        <element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{selectedKeywords}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>


I believe only one keyword can be specified here

Suggested change

<element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{selectedKeywords}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>

<element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{keyword}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>

sivaschenko

Thanks for updates @yolouiese ! Please see my comments on the naming. I think it can be improved a bit to make the action groups easier to reuse

sivaschenko · 2020-08-14T09:05:27Z

.../MediaGalleryUi/Test/Mftf/ActionGroup/AdminMediaGalleryEditAssetRemoveKeywordActionGroup.xml

+            <description>Remove Keywords on the Edit Details panel</description>
+        </annotations>
+        <arguments>
+            <argument name="selectedKeywords"/>


I'd change the name and specify a type to make it more clear how to use this action group

Suggested change

<argument name="selectedKeywords"/>

<argument name="keyword" type="string"/>

sivaschenko · 2020-08-14T09:06:45Z

...yUi/Test/Mftf/ActionGroup/AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup">


Suggested change

<actionGroup name="AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup">

<actionGroup name="AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup">

sivaschenko · 2020-08-14T09:06:59Z

...yUi/Test/Mftf/ActionGroup/AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup.xml

+            <description>Verifies removed image keywords on the View Details panel</description>
+        </annotations>
+        <arguments>
+            <argument name="keywords"/>


Suggested change

<argument name="keywords"/>

<argument name="keywords" type="string"/>

sivaschenko · 2020-08-14T09:08:12Z

...yUi/Test/Mftf/ActionGroup/AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup.xml

+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup">
+        <annotations>
+            <description>Verifies removed image keywords on the View Details panel</description>


Suggested change

<description>Verifies removed image keywords on the View Details panel</description>

<description>Verifies that the passed comma-separated list of keywords are not present on the View Details panel</description>

…eleted-tags-not-removed

yolouiese · 2020-08-14T12:06:26Z

@magento run all tests

…til the web page is refreshed - added requested changes

magento-engcom-team · 2020-08-14T14:09:42Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8015 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Lima · 2020-08-17T16:23:36Z

✔️ QA Passed

Tags successfully removed

Manual testing scenario

…own until the web page is refreshed #29400

m2-assistant · 2020-08-19T10:43:21Z

Hi @yolouiese, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#1703: The deleted tags are not removed from Tags drop-down un…

b2b45e6

…til the web page is refreshed - replaced outdated keywords after saving new details

yolouiese added the Project: ASI label Aug 5, 2020

yolouiese requested review from sivaschenko and gabrieldagama August 5, 2020 11:19

ghost added the Progress: pending review label Aug 5, 2020

magento-engcom-team added Area: Frontend Component: MediaGalleryUi Release Line: 2.4 labels Aug 5, 2020

yolouiese mentioned this pull request Aug 5, 2020

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed magento/adobe-stock-integration#1718

Closed

sivaschenko requested changes Aug 5, 2020

View reviewed changes

ghost assigned sivaschenko Aug 5, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 5, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Aug 5, 2020

Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…

c716884

…eleted-tags-not-removed

jmonteros422 mentioned this pull request Aug 10, 2020

#1709: Modified date is not updated when Editing image Tags the second time #29424

Merged

4 tasks

yolouiese added 3 commits August 10, 2020 22:01

Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…

9a2f265

…eleted-tags-not-removed

magento#1703: The deleted tags are not removed from Tags drop-down un…

8d9d0a5

…til the web page is refreshed - covered MFTF test

Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…

512942e

…eleted-tags-not-removed

sivaschenko requested changes Aug 11, 2020

View reviewed changes

yolouiese added 2 commits August 11, 2020 21:19

magento#1703: The deleted tags are not removed from Tags drop-down un…

7e34bc9

…til the web page is refreshed - covered MFTF test

magento#1703: The deleted tags are not removed from Tags drop-down un…

0f9189e

…til the web page is refreshed - covered MFTF test

yolouiese added 2 commits August 12, 2020 17:54

Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…

c4055cc

…eleted-tags-not-removed

magento#1703: The deleted tags are not removed from Tags drop-down un…

3b350fd

…til the web page is refreshed - added verify removal of keyword MFTF test

sivaschenko reviewed Aug 14, 2020

View reviewed changes

sivaschenko requested changes Aug 14, 2020

View reviewed changes

Merge branch '2.4-develop' of github.com:magento/magento2 into 1703-d…

bf77de0

…eleted-tags-not-removed

magento#1703: The deleted tags are not removed from Tags drop-down un…

5f1d43a

…til the web page is refreshed - added requested changes

sivaschenko approved these changes Aug 14, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 14, 2020

sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 14, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 17, 2020

engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 17, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 17, 2020

ghost added Progress: accept and removed Progress: extended testing labels Aug 18, 2020

magento-engcom-team mentioned this pull request Aug 19, 2020

when multiple productInterface implement which to use #1703

Closed

magento-engcom-team pushed a commit that referenced this pull request Aug 19, 2020

ENGCOM-8015: #1703: The deleted tags are not removed from Tags drop-d…

fd6319c

…own until the web page is refreshed #29400

magento-engcom-team merged commit 6f55df0 into magento:2.4-develop Aug 19, 2020

sidolov added this to the 2.4.2 milestone Aug 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

yolouiese commented Aug 5, 2020 •

edited

Loading

m2-assistant bot commented Aug 5, 2020

yolouiese commented Aug 5, 2020

sivaschenko left a comment

sivaschenko left a comment

sivaschenko Aug 11, 2020

sivaschenko Aug 11, 2020

sivaschenko Aug 11, 2020

yolouiese commented Aug 11, 2020

yolouiese commented Aug 12, 2020

sivaschenko commented Aug 13, 2020

sivaschenko Aug 14, 2020

sivaschenko left a comment

sivaschenko Aug 14, 2020

sivaschenko Aug 14, 2020

sivaschenko Aug 14, 2020

sivaschenko Aug 14, 2020

yolouiese commented Aug 14, 2020

magento-engcom-team commented Aug 14, 2020

engcom-Lima commented Aug 17, 2020

m2-assistant bot commented Aug 19, 2020

	<element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{selectedKeywords}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>
	<element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{keyword}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>

	<argument name="selectedKeywords"/>
	<argument name="keyword" type="string"/>

	<actionGroup name="AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup">
	<actionGroup name="AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup">

	<argument name="keywords"/>
	<argument name="keywords" type="string"/>

	<description>Verifies removed image keywords on the View Details panel</description>
	<description>Verifies that the passed comma-separated list of keywords are not present on the View Details panel</description>

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed #29400

Conversation

yolouiese commented Aug 5, 2020 • edited Loading

Need to verify (*)

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Aug 5, 2020

yolouiese commented Aug 5, 2020

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yolouiese commented Aug 11, 2020

yolouiese commented Aug 12, 2020

sivaschenko commented Aug 13, 2020

Choose a reason for hiding this comment

sivaschenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yolouiese commented Aug 14, 2020

magento-engcom-team commented Aug 14, 2020

engcom-Lima commented Aug 17, 2020

m2-assistant bot commented Aug 19, 2020

yolouiese commented Aug 5, 2020 •

edited

Loading