Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date timestamp typo ( Created and Modified date are different for newly saved Image Preview) #29452

Merged
merged 7 commits into from
Aug 19, 2020
Merged

Fix date timestamp typo ( Created and Modified date are different for newly saved Image Preview) #29452

merged 7 commits into from
Aug 19, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 10, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Created and Modified date are different for newly saved Image Preview adobe-stock-integration#1708: Created and Modified date are different for newly saved Image Preview

Manual testing scenarios (*)

  1. Go to Content - Media Gallery
  2. Click Search Adobe Stock and Save an image Preview
  3. Select the previously saved preview image
  4. Click "three dots", select View Details
  5. Observe the Created and Modified dates

The Created and Modified dates should be equal

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 10, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 10, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 10, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 10, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 10, 2020

@magento run all tests

@rogyar rogyar self-assigned this Aug 10, 2020
rogyar
rogyar requested changes Aug 10, 2020
View reviewed changes
...tionGroup/AdminEnhancedMediaGalleryVerifyImageCreatedAtNotEqualsUpdatedAtTimeActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminEnhancedMediaGalleryVerifyImageCreatedAtNotEqualsUpdatedAtTimeActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use the "Assert" prefix for similar checks. So we have consistent naming for such cases. I would suggest the following name for the action group

AssertAdminEnhancedMediaGalleryImageCreatedAtNotEqualsUpdatedAtTimeActionGroup

...t/Mftf/ActionGroup/AdminEnhancedMediaGalleryVerifyUploadedImageDateTimeEqualsActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminEnhancedMediaGalleryVerifyUploadedImageDateTimeEqualsActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use the "AssertAdmin" prefix in the same way as it was mentioned in the previous comment.

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 10, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 11, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 11, 2020

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7988 has been created to process this Pull Request

@engcom-Lima engcom-Lima self-assigned this Aug 11, 2020
@engcom-Lima
Copy link
Contributor

✔️ QA Passed
The Created and Modified dates are equal
Screenshot_75
Created and Modified dates are displayed correctly after editing for locally uploaded images
Screenshot_76
Manual testing scenario

@engcom-Lima engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7988 has been created to process this Pull Request

@engcom-Lima
Copy link
Contributor

✔️ QA Passed
The Created and Modified dates are equal
Screenshot_99
Created and Modified dates are displayed correctly after editing
Screenshot_98
See depended comment

magento-engcom-team pushed a commit that referenced this pull request Aug 19, 2020
@gabrieldagama
ENGCOM-7988: Fix date timestamp typo ( Created and Modified date are …
c44c07e 
…different for newly saved Image Preview) #29452
@magento-engcom-team magento-engcom-team merged commit d413f88 into magento:2.4-develop Aug 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov added this to the 2.4.2 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@rogyar rogyar rogyar approved these changes

Assignees

@sivaschenko sivaschenko

@rogyar rogyar

@engcom-Lima engcom-Lima

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: MediaGallerySynchronization Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Created and Modified date are different for newly saved Image Preview
7 participants
@Nazar65 @magento-engcom-team @engcom-Lima @sivaschenko @rogyar @sidolov @engcom-Golf